Open
Conversation
|
Great use of an if-elsif-else statement and complex conditionals! I like how you implemented the "or" operator in line 6. (Normally I shy away from using so many in a row, but it makes sense since you've already checked to make sure BOTH aren't nil). Nice job! :) |
Collaborator
|
Nice work! 👍 |
sloekito
reviewed
Apr 13, 2019
| return true | ||
| elsif array1 == nil || array2 == nil || array1.count != array2.count | ||
| return false | ||
| else |
There was a problem hiding this comment.
You do not need this else. If you have not returned in line 4 or line 7, you will hit this line.
sloekito
reviewed
Apr 13, 2019
| elsif array1 == nil || array2 == nil || array1.count != array2.count | ||
| return false | ||
| else | ||
| i = 0 |
There was a problem hiding this comment.
You don't need to initialize i to 0 since you do that in line 10.
sloekito
reviewed
Apr 13, 2019
sloekito
left a comment
sloekito
left a comment
There was a problem hiding this comment.
Great work! Very small suggestions for cleaner code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.